Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable publish servicedefinition to metadata center #2025

Merged
merged 8 commits into from Sep 24, 2022

Conversation

Leospard
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:
fix zk invalid path when metadata-type: remote

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #2025 (b2e2641) into 3.0 (d924219) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #2025      +/-   ##
==========================================
- Coverage   44.84%   44.60%   -0.25%     
==========================================
  Files         283      283              
  Lines       17150    17111      -39     
==========================================
- Hits         7691     7632      -59     
- Misses       8648     8672      +24     
+ Partials      811      807       -4     
Impacted Files Coverage Δ
metadata/definition/definition.go 70.66% <ø> (-1.06%) ⬇️
metadata/identifier/base_metadata_identifier.go 86.48% <0.00%> (-7.75%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
cluster/cluster/base/cluster_invoker.go 24.44% <0.00%> (-13.34%) ⬇️
cluster/loadbalance/ringhash/ring.go 84.50% <0.00%> (-2.82%) ⬇️
metrics/prometheus/reporter.go 31.79% <0.00%> (+1.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Leospard Leospard changed the base branch from 3.1 to 3.0 August 24, 2022 08:42
@chickenlj chickenlj added this to the v3.0.3 milestone Aug 25, 2022
@AlexStocks
Copy link
Contributor

@Leospard 如果这个工作做完,准备好让大家review,请把 title 中的 WIP 去掉

@@ -43,6 +47,10 @@ type BaseMetadataIdentifier struct {
func joinParams(joinChar string, params []string) string {
var joinedStr string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string change strings.Builder?

@Leospard Leospard changed the title [WIP] Enable publish servicedefinition to metadata center Enable publish servicedefinition to metadata center Sep 20, 2022
@AlexStocks AlexStocks merged commit 5268c26 into apache:3.0 Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants