Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update style and out-of-date links in readme #2079

Merged
merged 2 commits into from Oct 17, 2022

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Oct 17, 2022

Signed-off-by: Xuewei Niu justxuewei@apache.org

What this PR does:

Update style and out-of-date links in readme.

Which issue(s) this PR fixes:
Fixes #2063

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

Signed-off-by: Xuewei Niu <justxuewei@apache.org>
Signed-off-by: Xuewei Niu <justxuewei@apache.org>
@AlexStocks AlexStocks merged commit d80ee9c into apache:3.0 Oct 17, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants