Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#207: common/utils/net_test.go:25 cannot pass #208

Closed
wants to merge 2 commits into from
Closed

fix issue#207: common/utils/net_test.go:25 cannot pass #208

wants to merge 2 commits into from

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Sep 18, 2019

What this PR does:

Which issue(s) this PR fixes:

Fixes #207

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #208 into master will increase coverage by 1.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   66.62%   67.66%   +1.04%     
==========================================
  Files          94       94              
  Lines        5821     5824       +3     
==========================================
+ Hits         3878     3941      +63     
+ Misses       1541     1478      -63     
- Partials      402      405       +3
Impacted Files Coverage Δ
common/utils/net.go 68.57% <66.66%> (-3.31%) ⬇️
registry/etcdv3/registry.go 56.89% <0%> (+1.14%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 80.64% <0%> (+2.15%) ⬆️
protocol/dubbo/readwriter.go 70.37% <0%> (+2.46%) ⬆️
protocol/dubbo/codec.go 82.35% <0%> (+5.88%) ⬆️
protocol/dubbo/listener.go 64.02% <0%> (+14.02%) ⬆️
protocol/dubbo/pool.go 73.6% <0%> (+15.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf8f0e...9961541. Read the comment docs.

@beiwei30 beiwei30 closed this Sep 18, 2019
@beiwei30 beiwei30 deleted the issue207 branch September 18, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common/utils/net_test.go:25 cannot pass
2 participants