Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2123] Feat/polaris ratelimit #2128

Merged
merged 6 commits into from Nov 21, 2022

Conversation

chuntaojun
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:
Fixes #2123

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2128 (f0949de) into 3.0 (d70b6c0) will increase coverage by 0.06%.
The diff coverage is 60.60%.

@@            Coverage Diff             @@
##              3.0    #2128      +/-   ##
==========================================
+ Coverage   44.31%   44.37%   +0.06%     
==========================================
  Files         282      283       +1     
  Lines       16982    17015      +33     
==========================================
+ Hits         7525     7550      +25     
- Misses       8668     8673       +5     
- Partials      789      792       +3     
Impacted Files Coverage Δ
remoting/polaris/builder.go 30.00% <33.33%> (+0.21%) ⬆️
remoting/polaris/parser/parser.go 63.33% <63.33%> (ø)
metrics/prometheus/reporter.go 31.79% <0.00%> (+1.53%) ⬆️
cluster/loadbalance/ringhash/ring.go 87.32% <0.00%> (+2.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit 40ce3ba into apache:3.0 Nov 21, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants