refactor: remove providers and add prefix when use polaris #2274

chuntaojun · 2023-03-28T07:44:57Z

What this PR does:

Which issue(s) this PR fixes:
Fixes apache/dubbo-spi-extensions#204

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

All ut passed (run 'go test ./...' in project root)
After go-fmt ed , run 'go fmt project' using goland.
Golangci-lint passed, run 'sudo golangci-lint run' in project root.
Your new-created file needs to have apache license at the top, like other existed file does.
All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

chickenlj · 2023-03-28T11:18:43Z

This looks like a bugfix. Do you think this needs to be included in the next 3.0.x release, or it's ok to be just included in 3.1.

chickenlj

LGTM.

justxuewei

Thanks @chuntaojun, but here is a comment.

AlexStocks · 2023-03-28T13:50:13Z

@chuntaojun pls fix the ci failure.

registry/polaris/registry.go

AlexStocks · 2023-03-29T13:07:24Z

@chuntaojun pls fix the ci failure.

justxuewei · 2023-03-29T14:27:23Z

Please pull the latest commits after #2280 is merged to address the CI issues.

github-advanced-security · 2023-03-29T16:29:11Z

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

chuntaojun · 2023-03-30T02:07:13Z

included in the next 3.0.x release

hope included in the next 3.0.x release，tks

justxuewei · 2023-04-03T03:02:03Z

hope included in the next 3.0.x release，tks

You should backport this to 3.0 branch. That is, you should open a new pull request whose target branch is 3.0.

Btw, the CI of your PR is not up-to-date. That is why your CI failed. Please pull the latest commit from the main branch and rebase onto it.

For example:

justxuewei · 2023-04-07T09:47:57Z

Please rebase your PR onto the latest main branch to address the CI failure.

sonarcloud · 2023-04-07T12:48:04Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

codecov-commenter · 2023-04-07T13:05:25Z

Codecov Report

Merging #2274 (75f350d) into main (3fcc135) will decrease coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 75f350d differs from pull request most recent head c8f520a. Consider uploading reports for the commit c8f520a to get more accurate results

@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
- Coverage   44.23%   43.96%   -0.27%     
==========================================
  Files         289      284       -5     
  Lines       17916    17418     -498     
==========================================
- Hits         7925     7658     -267     
+ Misses       9149     8949     -200     
+ Partials      842      811      -31

Impacted Files	Coverage Δ
protocol/dubbo3/dubbo3_invoker.go	`58.33% <ø> (-1.44%)`	⬇️
protocol/dubbo3/dubbo3_protocol.go	`56.02% <ø> (-5.09%)`	⬇️
protocol/grpc/client.go	`60.25% <ø> (-3.75%)`	⬇️
protocol/grpc/server.go	`63.44% <ø> (-3.23%)`	⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

justxuewei

Lgtm, thanks! I left one comment here.

justxuewei · 2023-04-09T03:28:14Z

registry/polaris/registry.go

 	request.Namespace = pr.namespace
 	if err := pr.provider.Deregister(request); err != nil {
-		return perrors.WithMessagef(err, "register(conf:%+v)", conf)
+		return perrors.WithMessagef(err, "fail to deregister(conf:%+v)", url)


Suggested change

return perrors.WithMessagef(err, "fail to deregister(conf:%+v)", url)

return perrors.WithMessagef(err, "failed to deregister service from the Polaris registry, url = %v", url)

justxuewei · 2023-04-09T03:30:45Z

Btw, please link an issue, see here CONTRIBUTING.md.

AlexStocks · 2023-04-09T03:55:05Z

Btw, please link an issue, see here CONTRIBUTING.md.

agree with you. @chuntaojun

chuntaojun · 2023-04-22T12:09:36Z

already link issue

chuntaojun changed the title ~~Refactor/register service~~ refactor:remove providers: prefix when use polaris Mar 28, 2023

chickenlj self-requested a review March 28, 2023 11:29

chickenlj approved these changes Mar 28, 2023

View reviewed changes

justxuewei reviewed Mar 28, 2023

View reviewed changes

AlexStocks changed the title ~~refactor:remove providers: prefix when use polaris~~ refactor: remove providers and add prefix when use polaris Mar 28, 2023

justxuewei reviewed Mar 28, 2023

View reviewed changes

registry/polaris/registry.go Outdated Show resolved Hide resolved

chuntaojun force-pushed the refactor/register_service branch from 03258da to 5a76a5e Compare March 29, 2023 16:28

chuntaojun added 5 commits April 7, 2023 20:47

fix:issue apache#2216

1a6f111

fix:issue apache#2216

f9e53ab

fix:注册服务信息不带前缀

1682d4a

refactor:remove providers: prefix when use polaris

0f47c65

refactor:remove providers: prefix when use polaris

c8f520a

chuntaojun force-pushed the refactor/register_service branch from 044d1ad to c8f520a Compare April 7, 2023 12:47

justxuewei approved these changes Apr 9, 2023

View reviewed changes

AlexStocks approved these changes Apr 9, 2023

View reviewed changes

jasondeng1997 approved these changes Apr 22, 2023

View reviewed changes

AlexStocks merged commit 8f8f514 into apache:main May 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove providers and add prefix when use polaris #2274

refactor: remove providers and add prefix when use polaris #2274

chuntaojun commented Mar 28, 2023 •

edited

Loading

chickenlj commented Mar 28, 2023

chickenlj left a comment

justxuewei left a comment

AlexStocks commented Mar 28, 2023

AlexStocks commented Mar 29, 2023

justxuewei commented Mar 29, 2023

github-advanced-security bot commented Mar 29, 2023

chuntaojun commented Mar 30, 2023

justxuewei commented Apr 3, 2023 •

edited

Loading

justxuewei commented Apr 7, 2023

sonarcloud bot commented Apr 7, 2023

codecov-commenter commented Apr 7, 2023

justxuewei left a comment

justxuewei Apr 9, 2023

justxuewei commented Apr 9, 2023 •

edited

Loading

AlexStocks commented Apr 9, 2023

chuntaojun commented Apr 22, 2023

	return perrors.WithMessagef(err, "fail to deregister(conf:%+v)", url)
	return perrors.WithMessagef(err, "failed to deregister service from the Polaris registry, url = %v", url)

refactor: remove providers and add prefix when use polaris #2274

refactor: remove providers and add prefix when use polaris #2274

Conversation

chuntaojun commented Mar 28, 2023 • edited Loading

chickenlj commented Mar 28, 2023

chickenlj left a comment

Choose a reason for hiding this comment

justxuewei left a comment

Choose a reason for hiding this comment

AlexStocks commented Mar 28, 2023

AlexStocks commented Mar 29, 2023

justxuewei commented Mar 29, 2023

github-advanced-security bot commented Mar 29, 2023

chuntaojun commented Mar 30, 2023

justxuewei commented Apr 3, 2023 • edited Loading

justxuewei commented Apr 7, 2023

sonarcloud bot commented Apr 7, 2023

codecov-commenter commented Apr 7, 2023

Codecov Report

justxuewei left a comment

Choose a reason for hiding this comment

justxuewei Apr 9, 2023

Choose a reason for hiding this comment

justxuewei commented Apr 9, 2023 • edited Loading

AlexStocks commented Apr 9, 2023

chuntaojun commented Apr 22, 2023

chuntaojun commented Mar 28, 2023 •

edited

Loading

justxuewei commented Apr 3, 2023 •

edited

Loading

justxuewei commented Apr 9, 2023 •

edited

Loading