Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format imports in metrics module #2323

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

ev1lQuark
Copy link
Contributor

Fix: #2310

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #2323 (abf0e54) into main (66a152c) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head abf0e54 differs from pull request most recent head 51be17a. Consider uploading reports for the commit 51be17a to get more accurate results

@@            Coverage Diff             @@
##             main    #2323      +/-   ##
==========================================
- Coverage   44.27%   44.14%   -0.13%     
==========================================
  Files         293      289       -4     
  Lines       17892    17700     -192     
==========================================
- Hits         7922     7814     -108     
+ Misses       9120     9059      -61     
+ Partials      850      827      -23     
Impacted Files Coverage Δ
metrics/prometheus/after_invocation.go 94.28% <ø> (ø)
metrics/prometheus/api.go 0.00% <ø> (ø)
metrics/prometheus/common.go 47.54% <ø> (ø)
metrics/prometheus/metric_set.go 100.00% <ø> (ø)
metrics/prometheus/reporter.go 44.44% <ø> (-19.45%) ⬇️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit 05a7fc0 into apache:main May 30, 2023
6 checks passed
@ev1lQuark ev1lQuark deleted the fix branch June 5, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants