fix: disable metrics filter by default instead #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2354 +/- ##
==========================================
+ Coverage 43.94% 44.15% +0.21%
==========================================
Files 294 294
Lines 18019 18019
==========================================
+ Hits 7919 7957 +38
+ Misses 9257 9214 -43
- Partials 843 848 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable multiple dubbo go instances, the metrics function is enabled by default and the default port of the Prometheus server is 9000, which will cause port occupation problems. It is better to turn off the metrics function by default, and leave it to the user to decide whether to enable it and enable port configuration.
启用多个 dubbo go 实例，metrics 功能默认开启且 Prometheus server 默认端口为9000，会产生端口占用的问题。不如默认关闭 metrics 功能，是否启用以及启用端口配置交由用户来做决定。