Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve ConsumerConfig nil pointer problem #2440

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

DMwangnima
Copy link
Contributor

This PR aims to solve this issue(#2439).

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #2440 (c19e80a) into main (debe37d) will decrease coverage by 0.01%.
The diff coverage is 8.33%.

❗ Current head c19e80a differs from pull request most recent head 4d580bc. Consider uploading reports for the commit 4d580bc to get more accurate results

@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
- Coverage   45.08%   45.08%   -0.01%     
==========================================
  Files         269      269              
  Lines       18167    18168       +1     
==========================================
  Hits         8191     8191              
+ Misses       9104     9102       -2     
- Partials      872      875       +3     
Files Coverage Δ
config/reference_config.go 28.08% <8.33%> (+4.40%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chickenlj chickenlj merged commit 3764ba4 into apache:main Oct 11, 2023
6 checks passed
@DMwangnima DMwangnima deleted the fix-consumer_nil_pointer branch October 11, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants