Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dubbo/invoker): 修改dubbo 关闭的方式 #268

Merged
merged 1 commit into from Dec 9, 2019

Conversation

xujianhai666
Copy link
Member

What this PR does:
advance the destroy impl of dubboInvoker

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE


@codecov-io
Copy link

Codecov Report

Merging #268 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #268      +/-   ##
===========================================
+ Coverage    66.38%   66.38%   +<.01%     
===========================================
  Files          111      111              
  Lines         7038     7033       -5     
===========================================
- Hits          4672     4669       -3     
  Misses        1907     1907              
+ Partials       459      457       -2
Impacted Files Coverage Δ
protocol/dubbo/dubbo_invoker.go 92.3% <100%> (+8.21%) ⬆️
config_center/apollo/impl.go 84.41% <0%> (-2.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4014c59...17a63bf. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit a253564 into apache:develop Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants