Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nacos SDK version #548

Merged
merged 5 commits into from Jun 6, 2020
Merged

Update Nacos SDK version #548

merged 5 commits into from Jun 6, 2020

Conversation

lzp0412
Copy link
Contributor

@lzp0412 lzp0412 commented May 31, 2020

What this PR does:

  1. update nacos-sdk-go version to v0.3.2, this version fix some bug;
  2. optimized nacos config code

lzp0412 and others added 2 commits May 30, 2020 16:45
@AlexStocks
Copy link
Contributor

@lzp0412 pls change the title. I can not understand what's the meaning of it.

@AlexStocks AlexStocks requested review from flycash and zouyx and removed request for flycash May 31, 2020 07:42
@lzp0412 lzp0412 changed the title 1.4 Update Nacos SDK version May 31, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #548 into 1.4 will decrease coverage by 0.37%.
The diff coverage is 51.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.4     #548      +/-   ##
==========================================
- Coverage   67.24%   66.87%   -0.38%     
==========================================
  Files         174      174              
  Lines        9261     9259       -2     
==========================================
- Hits         6228     6192      -36     
- Misses       2428     2454      +26     
- Partials      605      613       +8     
Impacted Files Coverage Δ
common/url.go 70.71% <0.00%> (-0.45%) ⬇️
config_center/nacos/listener.go 68.18% <0.00%> (-11.82%) ⬇️
config_center/nacos/client.go 65.74% <55.88%> (+8.47%) ⬆️
registry/nacos/registry.go 62.69% <100.00%> (+0.90%) ⬆️
config_center/nacos/facade.go 37.50% <0.00%> (-34.38%) ⬇️
protocol/dubbo/listener.go 57.52% <0.00%> (-5.38%) ⬇️
protocol/dubbo/codec.go 72.50% <0.00%> (-5.00%) ⬇️
protocol/dubbo/pool.go 76.71% <0.00%> (-4.57%) ⬇️
protocol/dubbo/readwriter.go 68.29% <0.00%> (-2.44%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0.00%> (-2.16%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50325b...77e0765. Read the comment docs.

@zouyx zouyx requested a review from flycash June 1, 2020 08:27
config_center/nacos/client.go Outdated Show resolved Hide resolved
config_center/nacos/client.go Outdated Show resolved Hide resolved
config_center/nacos/client.go Outdated Show resolved Hide resolved
config_center/nacos/client.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 428fe1a into apache:1.4 Jun 6, 2020
lzp0412 added a commit to lzp0412/dubbo-go that referenced this pull request Jul 16, 2020
Merge pull request apache#548 from lzp0412/1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants