Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rft: modify registry panic msg #583

Merged
merged 2 commits into from Jun 3, 2020
Merged

Rft: modify registry panic msg #583

merged 2 commits into from Jun 3, 2020

Conversation

ZYB-J
Copy link

@ZYB-J ZYB-J commented Jun 3, 2020

What this PR does:
modify_registry_panic_msg
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
no


@codecov-commenter
Copy link

Codecov Report

Merging #583 into develop will decrease coverage by 0.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #583      +/-   ##
===========================================
- Coverage    67.20%   66.36%   -0.85%     
===========================================
  Files          174      184      +10     
  Lines         9261     9709     +448     
===========================================
+ Hits          6224     6443     +219     
- Misses        2432     2624     +192     
- Partials       605      642      +37     
Impacted Files Coverage Δ
common/extension/registry.go 0.00% <0.00%> (ø)
config_center/nacos/facade.go 37.50% <0.00%> (-25.00%) ⬇️
registry/zookeeper/registry.go 46.15% <0.00%> (-9.30%) ⬇️
protocol/dubbo/listener.go 57.52% <0.00%> (-5.38%) ⬇️
common/url.go 65.83% <0.00%> (-5.33%) ⬇️
protocol/dubbo/pool.go 76.81% <0.00%> (-4.47%) ⬇️
config_center/nacos/impl.go 71.08% <0.00%> (-4.31%) ⬇️
config_center/apollo/impl.go 82.71% <0.00%> (-4.30%) ⬇️
remoting/zookeeper/facade.go 70.27% <0.00%> (-4.02%) ⬇️
config/provider_config.go 55.88% <0.00%> (-3.50%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3c02c...ad60db4. Read the comment docs.

@zouyx zouyx changed the title modify_registry_panic_msg Rft: modify registry panic msg Jun 3, 2020
@zouyx zouyx merged commit 0a08cda into apache:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants