Ftr: move task pool to endpoint layer #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watermelo
changed the title
|
Related PR: |
AlexStocks
reviewed
Dec 1, 2020
Codecov Report
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 59.91% 59.85% -0.06%
===========================================
Files 261 261
Lines 12912 12884 -28
===========================================
- Hits 7736 7712 -24
+ Misses 4224 4218 -6
- Partials 952 954 +2
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Dec 5, 2020
gaoxinge
approved these changes
Dec 5, 2020
|
pls update dubbo-getty to v1.4.1 |
georgehao
approved these changes
Dec 25, 2020
zouyx
reviewed
Dec 25, 2020
remoting/getty/getty_server.go
Outdated
| } | ||
|
|
||
| if s.conf.GrPoolSize != 0 { |
There was a problem hiding this comment.
!= 0 ？what about < 0? Is that a right logic?
AlexStocks
force-pushed
the
opt_taskpool
branch
from
2cacfc7
to
d6bf494
Compare
AlexStocks
force-pushed
the
develop
branch
7 times, most recently
from
7906db6
to
8aba190
Compare
AlexStocks
force-pushed
the
develop
branch
4 times, most recently
from
70eb671
to
a276be8
Compare
AlexStocks
force-pushed
the
develop
branch
20 times, most recently
from
9ef971c
to
f11f1f9
Compare
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Ftr: move task pool to endpoint layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: