Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split registry module and extend Dubbo register #117

Merged
merged 2 commits into from Jun 10, 2019
Merged

split registry module and extend Dubbo register #117

merged 2 commits into from Jun 10, 2019

Conversation

hufeng
Copy link
Member

@hufeng hufeng commented Jun 8, 2019

  1. add more java provider get as close to the real scene as possible

  2. fixed setting bug

  3. fixed zookeeper Unreasonable code

  4. Next target split registry

@hufeng
1. add more java provider get as close to the real scene as possible …
15d4b35 
…2. fixed setting bug 3. fixed zookeeper Unreasonable code 4.Next target split registry
hufeng
hufeng commented Jun 9, 2019
View reviewed changes
Copy link
Member Author

@hufeng hufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralf0131 please help me review it.

@hufeng
Copy link
Member Author

hufeng commented Jun 9, 2019

@ralf0131 @creasy2010 @sunchuanleihit split registry module in order to extends more register, such as nacos, redis, and so on . please help me review it.

@hufeng hufeng mentioned this pull request Jun 9, 2019
Closed
@hufeng hufeng changed the title add more java provider get as close to the real scene as possible … split registry module and extend Dubbo register Jun 9, 2019
creasy2010
creasy2010 approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@creasy2010 creasy2010 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looking forward to the next step

ralf0131
ralf0131 approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit a10aea8 into apache:master Jun 10, 2019
@hufeng hufeng mentioned this pull request Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creasy2010 creasy2010 creasy2010 approved these changes

@ralf0131 ralf0131 ralf0131 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hufeng @creasy2010 @ralf0131