Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix decode-buffer return DataType.Data #144

Merged
merged 1 commit into from
Oct 21, 2019
Merged

bugfix decode-buffer return DataType.Data #144

merged 1 commit into from
Oct 21, 2019

Conversation

sunchuanleihit
Copy link
Contributor

No description provided.

@sunchuanleihit sunchuanleihit mentioned this pull request Oct 21, 2019
Closed
@sunchuanleihit
Copy link
Contributor Author

this bug will break data consume

@hufeng
Copy link
Member

hufeng commented Oct 21, 2019

@sunchuanleihit 这样会导致跳出while循环是吧

@sunchuanleihit
Copy link
Contributor Author

是的，出现一次错误后，后面的都不可用了，比较严重

@hufeng
Copy link
Member

hufeng commented Oct 21, 2019

@sunchuanleihit 是的，感谢三石的耐心细致。

确实会导致buffer队列积压大量的数据，导致解析数据的速度下降。

@hufeng hufeng merged commit 0a3e0f0 into apache:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunchuanleihit @hufeng