过滤private field不翻译 #151
Merged
过滤private field不翻译 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@hsiaosiyuan0 @sunchuanleihit please help review |
hsiaosiyuan0
reviewed
Nov 6, 2019
| @@ -62,21 +64,30 @@ export async function toBeanClass( | |||
| if (typeDef.fields[fieldName].isArray) { | |||
| filedType = typeDef.fields[fieldName].elementType.name; | |||
| } | |||
| const regex = new RegExp( | |||
| `^(get|set${fieldName.slice(0, 1).toUpperCase()}${fieldName.slice(1)})$`, | |||
There was a problem hiding this comment.
Please consider below test case:
const fieldName = 'name';
const regex = new RegExp(`^(get|set${fieldName.slice(0, 1).toUpperCase()}${fieldName.slice(1)})$`);
regex.test('getName'); // expect `true` but got `false`and then if we just want to capitalize the first character I think the better way is using fieldName[0].toUpperCase() directly, it's safe since fieldName can never be an empty string
There was a problem hiding this comment.
Oh, sorry. It's a typo. Please review it again.
There was a problem hiding this comment.
LGTM. It's up to @hufeng 😏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33