Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【3.2】 使用Protobuf做序列化器时,在INJVM模式会因为深度拷贝导致response字段为空 #267

Open
6 tasks done
vio-lin opened this issue Dec 27, 2023 · 1 comment

Comments

@vio-lin
Copy link
Contributor

vio-lin commented Dec 27, 2023

What is the purpose of the change

修复INJVM模式下 Protobuf对象,不能被正常深度拷贝

Brief changelog

dubbo-spi-extensions\dubbo-serialization-extensions\dubbo-serialization-protobuf\src\test\java\org\apache\dubbo\common\serialize\protobuf\support\ProtobufParamDeepCopyUtilTest.java

dubbo-spi-extensions\dubbo-serialization-extensions\dubbo-serialization-protobuf\src\main\resources\META-INF\dubbo\internal\org.apache.dubbo.rpc.protocol.injvm.ParamDeepCopyUtil

Verifying this change

增加一个wraper 扩展,假如继承protobuf的接口,则使用另外的序列化器。

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.
@aofall
Copy link
Contributor

aofall commented Apr 10, 2024

may be fixed in #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants