Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-spring-boot-actuator原因启动报错问题 #33

Closed
Comven opened this issue Feb 2, 2018 · 3 comments
Closed

dubbo-spring-boot-actuator原因启动报错问题 #33

Comven opened this issue Feb 2, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@Comven
Copy link

Comven commented Feb 2, 2018

现在引用dubbo-spring-boot-starter默认就会引入dubbo-spring-boot-actuator,但是如果应用程序未使用spring-boot-starter-actuator,那么程序启动会不成功,因为dubboEndpoint的暴露依赖了spring-boot-starter-actuator,这种情况是否应该在DubboEndpointAutoConfiguration中增加@conditional条件保证在最少依赖的条件下都可以正常启动dubbo程序。否则每个程序都必须引入spring-boot-starter-actuator,这样的话直接跟dubbo-spring-boot-starter直接引入spring-boot-starter-actuator有什么区别。在issue#26中既然应该由应用程序来决定是否引入,那么dubbo-spring-boot-starter就应该支持不引入该组件的情况才对吧。

@mercyblitz mercyblitz added the bug Something isn't working label Feb 3, 2018
@chenyf3
Copy link

chenyf3 commented Feb 3, 2018

我也出现了这个问题,这个问题除了需要引入spring-boot-starter-actuator,还需要强制引入spring-boot-starter-web,也是不合理的

@mercyblitz
Copy link
Contributor

mercyblitz commented Feb 3, 2018

@yufeng629 spring-boot-starter-actuator's dependency has been changed to be optional . However , spring-boot-starter-web always is optional . If application did not include spring-boot-starter-web, the dubbo-spring-boot-actuator could be used on JMX if available, thus spring-boot-starter-web is not a mandatory dependency.

@chenyf3
Copy link

chenyf3 commented Feb 5, 2018

i see, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants