You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@yufeng629 spring-boot-starter-actuator's dependency has been changed to be optional . However , spring-boot-starter-web always is optional . If application did not include spring-boot-starter-web, the dubbo-spring-boot-actuator could be used on JMX if available, thus spring-boot-starter-web is not a mandatory dependency.
现在引用dubbo-spring-boot-starter默认就会引入dubbo-spring-boot-actuator,但是如果应用程序未使用spring-boot-starter-actuator,那么程序启动会不成功,因为dubboEndpoint的暴露依赖了spring-boot-starter-actuator,这种情况是否应该在DubboEndpointAutoConfiguration中增加@conditional条件保证在最少依赖的条件下都可以正常启动dubbo程序。否则每个程序都必须引入spring-boot-starter-actuator,这样的话直接跟dubbo-spring-boot-starter直接引入spring-boot-starter-actuator有什么区别。在issue#26中既然应该由应用程序来决定是否引入,那么dubbo-spring-boot-starter就应该支持不引入该组件的情况才对吧。
The text was updated successfully, but these errors were encountered: