Cleanup resoruce if qos start failed (#12993)

apache · Sep 1, 2023 · e436f1e · e436f1e
1 parent bfa46f5
commit e436f1e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java
@@ -134,6 +134,11 @@ private void startQosServer(URL url) throws RpcException {
 
         } catch (Throwable throwable) {
             logger.warn(QOS_FAILED_START_SERVER, "", "", "Fail to start qos server: ", throwable);
+            try {
+                stopServer();
+            } catch (Throwable stop) {
+                logger.warn(QOS_FAILED_START_SERVER, "", "", "Fail to stop qos server: ", stop);
+            }
             if (qosCheck) {
                 throw new RpcException(throwable);
             }

diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
@@ -137,6 +137,7 @@ public void stop() {
         if (worker != null) {
             worker.shutdownGracefully();
         }
+        started.set(false);
     }
 
     public String getHost() {