Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store old revisions #11241

Merged
merged 5 commits into from Jan 6, 2023
Merged

Store old revisions #11241

merged 5 commits into from Jan 6, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jan 5, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #11241 (34c48ee) into 3.1 (ad79c9e) will decrease coverage by 4.99%.
The diff coverage is 85.36%.

@@             Coverage Diff              @@
##                3.1   #11241      +/-   ##
============================================
- Coverage     69.40%   64.41%   -5.00%     
+ Complexity      119       14     -105     
============================================
  Files          1503     1422      -81     
  Lines         79579    59335   -20244     
  Branches      14039     8720    -5319     
============================================
- Hits          55231    38220   -17011     
+ Misses        19573    17051    -2522     
+ Partials       4775     4064     -711     
Impacted Files Coverage Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...apache/dubbo/registry/client/ServiceDiscovery.java 33.33% <0.00%> (-6.67%) ⬇️
...bo/registry/multiple/MultipleServiceDiscovery.java 0.00% <0.00%> (ø)
...try/client/metadata/MetadataServiceDelegation.java 35.41% <50.00%> (-4.17%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 77.71% <91.89%> (-9.47%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
... and 515 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

76.3% 76.3% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 4a1aa85 into apache:3.1 Jan 6, 2023
@chickenlj chickenlj added this to the 3.1.5 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants