Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-xds: remove Istio first-party-jwt dependency #12201

Open
howardjohn opened this issue Apr 26, 2023 · 5 comments
Open

dubbo-xds: remove Istio first-party-jwt dependency #12201

howardjohn opened this issue Apr 26, 2023 · 5 comments
Labels
type/discussion Everything related with code discussion or question

Comments

@howardjohn
Copy link

This is considered legacy in Istio and upstream is looking into removal: istio/istio#44585.

Can you help give some insight on the requirement for this in dubbo and if it can be dropped?

@howardjohn howardjohn added the type/discussion Everything related with code discussion or question label Apr 26, 2023
@AlbumenJ
Copy link
Member

The reason Dubbo needs first-party-jwt is that right now istio doesn't support injecting these configurations into Dubbo deployments. I think we can remove it after we have a nice way to inject templates.

@howardjohn
Copy link
Author

Istio already has a mechanism to inject arbitrary things, including the token into the app container. Similar example: https://github.com/istio/istio/blob/6e6dd6424d16331678ba11615a678a0c12f3508f/manifests/charts/istio-control/istio-discovery/files/grpc-simple.yaml#L49

@AlbumenJ
Copy link
Member

Istio already has a mechanism to inject arbitrary things, including the token into the app container. Similar example: https://github.com/istio/istio/blob/6e6dd6424d16331678ba11615a678a0c12f3508f/manifests/charts/istio-control/istio-discovery/files/grpc-simple.yaml#L49

This configuration is great and can solve most problems. However, I still have a question that the parameters injected by this template currently seem to be a bit "framework bound". This template looks like it has a one-to-one correspondence with the gRPC configuration. Or is it possible to provide a more general injection template in istio?

@howardjohn
Copy link
Author

Sorry for the confusion. The template is just an example one for gRPC (note this one is problematic, as it disables auth entirely, which is being worked on. But just an example of how injection can be used even without a sidecar)

https://istio.io/latest/docs/setup/additional-setup/sidecar-injection/#custom-templates-experimental shows how you can add completely arbitrary templates

@AlbumenJ
Copy link
Member

AlbumenJ commented May 2, 2023

The template configuration seems meet our needs. @aamingaa @CrazyHZM What do you think?

BTW, is it possible to provide dubbo's templates by default in istio. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/discussion Everything related with code discussion or question
Projects
None yet
Development

No branches or pull requests

2 participants