Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove zk3.4 support in 3.3 #13960

Open
3 of 4 tasks
AlbumenJ opened this issue Mar 20, 2024 · 6 comments
Open
3 of 4 tasks

[Feature] Remove zk3.4 support in 3.3 #13960

AlbumenJ opened this issue Mar 20, 2024 · 6 comments
Assignees
Labels
component/sdk Related with apache/dubbo good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance

Comments

@AlbumenJ
Copy link
Member

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Remove zk3.4 support in 3.3

  • Remove dubbo-dependencies-zookeeper, dubbo-remoting-zookeeper.
  • Rename all the zookeeper-curator5 related modules to zookeeper

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@AlbumenJ AlbumenJ added help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance good first issue Good for starters to contribute component/sdk Related with apache/dubbo labels Mar 20, 2024
@Stellar1999
Copy link
Contributor

I'm interested. Can you assign it to me?

@AlbumenJ
Copy link
Member Author

I'm interested. Can you assign it to me?

done

@Stellar1999
Copy link
Contributor

I'm interested. Can you assign it to me?

done

I realized that perhaps dubbo-zookeeper-curator5-spring-boot-starter needs to do the same things when I'm coding.Is that correct?

Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Mar 20, 2024
@Stellar1999
Copy link
Contributor

I find this PR can't pass CI because the CI project uses curator4.1, so it throws an error java.lang.NoSuchMethodError: org.apache.curator.framework.recipes.cache.NodeCache.getListenable()Lorg/apache/curator/framework/listen/Listenable; I have submitted another PR in the CI repository to try to fix this problem.
Refer: #19

Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 4, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 8, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 9, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Apr 11, 2024
@wcy666103
Copy link
Contributor

Is this issue completed? Is there any progress? I am very interested in this and want to join. @Stellar1999

@Stellar1999
Copy link
Contributor

Is this issue completed? Is there any progress? I am very interested in this and want to join. @Stellar1999

I believe it's nearly complete and just awaiting merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sdk Related with apache/dubbo good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance
Projects
Status: Todo
Development

No branches or pull requests

3 participants