-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InvokeTelnetHandler.findMethod 关于重载逻辑有问题 #257
Comments
27917f2 fixed this issue. |
能区分 enum 和 string 嘛,这两种重载的话,可能区分不了 |
我理解如果重载的话带来的问题比较多 其实比如retry timeout 这些参数都可以定义在方法级别上面 如果这样的话 其实我们在调用的过程中 dubbo拼接url都会去除重复项 这样很有可能导致你的配置其实不是你的预期 举个例子 |
这里如果有重载方法,判断之前的方法是否匹配,如果匹配,应该break,否则赋值,继续看下一个重载方法。
这个会导致测试的时候,用telnet invoke方式,重载方法测不了(不能正确匹配方法)
建议修正如下:
The text was updated successfully, but these errors were encountered: