Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2766]Fix 2766 and enhance the invoke command #2801

Merged
merged 13 commits into from
Dec 11, 2018

Conversation

kexianjun
Copy link
Member

What is the purpose of the change

Fix #2766 and enhance the invoke command

Brief changelog

enhance detail: add an option parameter(-p) to invoke command,make it possible to call methods with complex parameter types.
for example:

  1. we can use "invoke org.apache.dubbo.demo.provider.test.OverrideService.student({"name":"zhangsan", "age":12}) -p org.apache.dubbo.demo.provider.test.Student" to call a method with signature of “public void student(Student student)”
  2. we can also use "invoke org.apache.dubbo.demo.provider.test.OverrideService.student({"name":"zhangsan", "age":12}, {"schoolName":"hello"}) -p org.apache.dubbo.demo.provider.test.Student org.apache.dubbo.demo.provider.test.School" to call a method with signature of "public void student(Student student, School school)"
    3.if -p is not specify, the result is the same as the previous version

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #2801 into master will decrease coverage by 0.02%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2801      +/-   ##
==========================================
- Coverage   63.79%   63.76%   -0.03%     
==========================================
  Files         578      578              
  Lines       25959    25985      +26     
  Branches     4545     4554       +9     
==========================================
+ Hits        16560    16570      +10     
- Misses       7224     7235      +11     
- Partials     2175     2180       +5
Impacted Files Coverage Δ
...ting/telnet/support/command/HelpTelnetHandler.java 0% <0%> (ø) ⬆️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 71.92% <77.41%> (+17.38%) ⬆️
...ache/dubbo/remoting/transport/AbstractChannel.java 37.5% <0%> (-50%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-4.17%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 58.88% <0%> (-1.75%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.3%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 68.45% <0%> (-0.68%) ⬇️
.../java/org/apache/dubbo/common/utils/PojoUtils.java 70.55% <0%> (+0.29%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfc86f...c73a3ba. Read the comment docs.

@kexianjun kexianjun changed the title Fix 2766 and enhance the invoke command [Dubbo-2766]Fix 2766 and enhance the invoke command Nov 17, 2018
@kexianjun
Copy link
Member Author

@zonghaishang can you pls review it?

@beiwei30
Copy link
Member

@kexianjun I solved the conflict and merged your PR. Would you mind to verify and add doc to describe the new behavior, especially for the introduced parameter?

@beiwei30 beiwei30 merged commit d32ff60 into apache:master Dec 11, 2018
@kexianjun
Copy link
Member Author

@kexianjun I solved the conflict and merged your PR. Would you mind to verify and add doc to describe the new behavior, especially for the introduced parameter?

ok,I'll do it later.

khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Dec 17, 2018
* add getter and setter for ServiceConfig's interfaceName property#2353

* add interfaceName to ignoreAttributeNames and change the unit test

* delete the demo source code and update the unit test

* unchange ServiceConfig

* update unit test

* update unit test

* fix apache#2798 and enhance invoke command
beiwei30 pushed a commit that referenced this pull request Dec 17, 2018
* added dubbo-rpc-api filter documentation for issue no #2935

* wrong @see java.io.File was added, removed this version of checkins

* Close all ports after tests finish (#2906)

* fix testCustomExecutor (#2904)

* Graceful shutdown enhancement in Spring (#2901)

* Simplify the code logic of the method AbstractClusterInvoker#reselect. (#2826)

* Simplify the code logic of the method AbstractClusterInvoker#reselect.

* Minor modification for code style.

* create AbstractRouter (#2909)

* create AbstractRouter

* router default method

* router default method

* router default method

* mockinvoker

* Added javadoc for dubbo-filter module dubbo github issue 2884 (#2921)

* Enhance unit test (#2920)

* Change Readme dubbo-sample hyperlink (#2927)

* Simply TagRouter (#2924)

* make telnet config work again (#2925)

* Remove the log to putRandomPort when one protocol use random port (#2931)

* optimize findConfigedPorts method of ServiceConfig to log only one time when userandom port

* move the log to method putRandomPort

* Fix DubboShutdownHook Memory Leak (#2922)

* Improve UT grammar and remove unnecessary braces. (#2930)

* Improve UT grammer, fix compiler warnings.

* Remove unnecessary braces.

* re-enable testCustomExecutor  (#2917)

* fix testCustomExecutor

* fix ci

* Fixing test-order dependency for FstObjectInputTest (#2815)

* re-enable testCustomExecutor (#2913)

* Resetting ExtensionLoader to remove test order dependencies in StickyTest (#2807)

* optimize the RondRobinLoadBalance and MockClusterInvoker (#2932)

delete unused logic and take the logger out.

* [Dubbo-2864] Fix build failed with -Prelease (#2923)

fixes #2864

* Fix telnet can not find method with enum type (#2803)

* [dubbo-2766] fix the bug of isMatch method of InvokeTelnetHandler (#2787)

* enhance org.apache.dubbo.rpc.protocol.dubbo.telnet.InvokeTelnetHandler#isMatch (#2941)

* enhance isMatch

* remove useless imports

* [Dubbo-2766]Fix 2766 and enhance the invoke command (#2801)

* add getter and setter for ServiceConfig's interfaceName property#2353

* add interfaceName to ignoreAttributeNames and change the unit test

* delete the demo source code and update the unit test

* unchange ServiceConfig

* update unit test

* update unit test

* fix #2798 and enhance invoke command

* Delete useless assignments (#2939)

* Replace anonymous class with method reference (#2929)

* Replace anonymous class with method reference

* Revert changes as per @beiwei30 code review

* Optimize retry for FailbackRegistry. (#2763)

* Abstract retry task

* Task for retry.

* Fix sth.

* Finish Optimize. fix ci failed.

* Optimize retry for FailbackRegistry.
The retry operation splits into specific operations, such as subscriptions and registrations. This approach allows for very precise retry control.

* Optimize retry for FailbackRegistry.
The retry operation splits into specific operations, such as subscriptions and registrations. This approach allows for very precise retry control.

* Optimize logger warn's msg.

* Optimize FailedNotifiedTask's run method.
Optimize addXXXTask, directly return if we already have a retry task.

* Optimize notify logic, just notify when the urls is not empty.

* Optimize notify logic, just notify when the urls is not empty.

* Optimize timer that use daemon thread.

* standardize semantics of all mergers,enhance mergeFactory and testcase (#2936)

* Modified to lower camel case (#2945)

* Improve several map iteration (#2938)

* added dubbo-rpc-api filter documentation for issue no #2935

* wrong @see java.io.File was added, removed this version of checkins
@kexianjun kexianjun deleted the fix-2766 branch January 4, 2019 10:07
@qixiaobo
Copy link
Contributor

But the version 2.6.X not merge this pr……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dubbo - telnet] Unrecognized overload method
4 participants