Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate code #3070

Closed
ralf0131 opened this issue Dec 27, 2018 · 1 comment
Closed

Duplicate code #3070

ralf0131 opened this issue Dec 27, 2018 · 1 comment
Labels
help wanted Everything needs help from contributors

Comments

@ralf0131
Copy link
Contributor

  1. org.apache.dubbo.common.utils.ClassHelper#isTypeMatch
  2. org.apache.dubbo.config.AbstractConfig#isTypeMatch

The second one is never used, it can be removed.
@ralf0131 ralf0131 added help wanted Everything needs help from contributors good first issue labels Dec 27, 2018
@CrazyHZM
Copy link
Member

I will submit a pr to remove this duplicate code

CrazyHZM added a commit to CrazyHZM/dubbo that referenced this issue Dec 27, 2018
@CrazyHZM
fix apache#3070
982ff3e
@frank-zsy frank-zsy mentioned this issue Jan 7, 2019
Closed
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this issue Jan 18, 2019
@CrazyHZM @khanimteyaz
Remove unused code, fix apache#3070 (apache#3073)
e0f960a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Everything needs help from contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralf0131 @CrazyHZM