Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

只在提供者端设置retries=10,值10不会传递给消费者端,最终for循环的len值是3。 #8426

Closed
startjava opened this issue Aug 5, 2021 · 13 comments
Assignees
Labels
help wanted Everything needs help from contributors

Comments

@startjava
Copy link

@DubboService(retries = 10)

是否是bug?


但在消费者端使用@DubboReference(retries = 5)是正确的,一共循环6次。

@horizonzy
Copy link
Member

@haoyann pls see it.

@startjava
Copy link
Author

startjava commented Aug 6, 2021 via email

@haoyann
Copy link
Contributor

haoyann commented Aug 6, 2021

@horizonzy @startjava I will try.

@dkisser
Copy link

dkisser commented Aug 6, 2021

retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider

@horizonzy
Copy link
Member

retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider

It should be delivered, consumer side pick one provide node, it can get the provider node's retry times.

@haoyann
Copy link
Contributor

haoyann commented Aug 8, 2021

Because this line of code is commented out, consumer cannot merge provider parameters. Duplicate #8292.

// this.overrideDirectoryUrl = this.overrideDirectoryUrl.addParametersIfAbsent(providerUrl.getParameters()); // Merge the provider side parameters

@startjava
Copy link
Author

@haoyann 代码为什么要注释掉呢??如果这样,是不是只支持在客户端配置了,不支持在服务端配置了?

@dkisser
Copy link

dkisser commented Aug 10, 2021

retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider

It should be delivered, consumer side pick one provide node, it can get the provider node's retry times.

at least it can't be deliverd in FailoverClusterInvoker,because the retries were caculated before the Invoker selected。As for others it's OK.

@startjava
Copy link
Author

startjava commented Aug 10, 2021 via email

@startjava
Copy link
Author

文档是不是要修改一下,,不然这是误导。

@startjava
Copy link
Author

@haoyann 大佬,这个问题解决了吗?

@CrazyHZM CrazyHZM added help wanted Everything needs help from contributors type/suspicious labels Sep 23, 2021
@sunhk
Copy link

sunhk commented Oct 12, 2021

文档是不是要修改一下,,不然这是误导。

是啊,文档中竟然明确提到建议在provider端配置重试次数
https://dubbo.apache.org/zh/docsv2.7/user/recommend/#%E5%9C%A8-provider-%E7%AB%AF%E5%B0%BD%E9%87%8F%E5%A4%9A%E9%85%8D%E7%BD%AE-consumer-%E7%AB%AF%E5%B1%9E%E6%80%A7

@CrazyHZM
Copy link
Member

Resolved in #9147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Everything needs help from contributors
Projects
None yet
Development

No branches or pull requests

6 participants