Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] fix memory leak #10231

Merged
merged 1 commit into from Jun 29, 2022
Merged

[2.7] fix memory leak #10231

merged 1 commit into from Jun 29, 2022

Conversation

icodening
Copy link
Contributor

@icodening icodening commented Jun 29, 2022

What is the purpose of the change

fix #10219

Brief changelog

remove ThreadLocal from Hessian2ObjectInput and Hessian2ObjectOutput

Copy link

@flacocobot flacocobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flacoco flags 5 suspicious lines as the potential root cause of the test failure.

@icodening icodening closed this Jun 29, 2022
@icodening icodening reopened this Jun 29, 2022
@icodening icodening changed the title fix memory leak [2.7] fix memory leak Jun 29, 2022
@icodening
Copy link
Contributor Author

@AlbumenJ the pr had remove ThreadLocal to fix issue #10219, pls review

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #10231 (8d5a4cf) into master (c1a76a0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #10231      +/-   ##
============================================
+ Coverage     60.95%   60.98%   +0.02%     
- Complexity      448      449       +1     
============================================
  Files          1100     1100              
  Lines         44579    44511      -68     
  Branches       6493     6486       -7     
============================================
- Hits          27175    27143      -32     
+ Misses        14437    14404      -33     
+ Partials       2967     2964       -3     
Impacted Files Coverage Δ
...common/serialize/hessian2/Hessian2ObjectInput.java 90.47% <100.00%> (-1.53%) ⬇️
...ommon/serialize/hessian2/Hessian2ObjectOutput.java 93.93% <100.00%> (-0.66%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 68.44% <0.00%> (-1.07%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.74% <0.00%> (+2.59%) ⬆️
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (+2.81%) ⬆️
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 74.10% <0.00%> (+3.57%) ⬆️
...n/java/org/apache/dubbo/common/utils/LFUCache.java 86.27% <0.00%> (+5.41%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 46.05% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a76a0...8d5a4cf. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 7a0c805 into apache:master Jun 29, 2022
@icodening icodening deleted the fix_mem_leak branch December 26, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants