Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Files.newInputStream instead of new FileInputStream and null check #10847

Merged
merged 3 commits into from
Nov 2, 2022
Merged

use Files.newInputStream instead of new FileInputStream and null check #10847

merged 3 commits into from
Nov 2, 2022

Conversation

zhangzq7
Copy link
Contributor

AlbumenJ
AlbumenJ requested changes Nov 1, 2022
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix style check
image

AlbumenJ
AlbumenJ approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 1aa1aea into apache:3.1 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhangzq7 @AlbumenJ