Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 5900:add bytebuddy support #11117

Merged
merged 7 commits into from
Dec 20, 2022
Merged

issue 5900:add bytebuddy support #11117

merged 7 commits into from
Dec 20, 2022

Conversation

icodening
Copy link
Contributor

Proxy支持bytebuddy
#5900

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Merging #11117 (9b0099b) into 3.2 (66b8487) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                3.2   #11117      +/-   ##
============================================
- Coverage     64.86%   64.74%   -0.13%     
  Complexity       14       14              
============================================
  Files          1462     1468       +6     
  Lines         60915    61051     +136     
  Branches       8939     8953      +14     
============================================
+ Hits          39513    39526      +13     
- Misses        17221    17342     +121     
- Partials       4181     4183       +2     
Impacted Files Coverage Δ
...bbo/rpc/proxy/AbstractFallbackJdkProxyFactory.java 0.00% <0.00%> (ø)
...java/org/apache/dubbo/rpc/proxy/MethodInvoker.java 0.00% <0.00%> (ø)
...ubbo/rpc/proxy/bytebuddy/ByteBuddyInterceptor.java 0.00% <0.00%> (ø)
...ache/dubbo/rpc/proxy/bytebuddy/ByteBuddyProxy.java 0.00% <0.00%> (ø)
...bbo/rpc/proxy/bytebuddy/ByteBuddyProxyFactory.java 0.00% <0.00%> (ø)
...bbo/rpc/proxy/bytebuddy/ByteBuddyProxyInvoker.java 0.00% <0.00%> (ø)
...o/remoting/exchange/support/ReplierDispatcher.java 72.72% <0.00%> (-9.10%) ⬇️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-5.27%) ⬇️
...try/client/metadata/MetadataServiceDelegation.java 38.04% <0.00%> (-3.27%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.64% <0.00%> (-3.23%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit test cases to verify

@icodening
Copy link
Contributor Author

Please add some unit test cases to verify

OK

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ
Copy link
Member

Please fix failed uts
image

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

70.8% 70.8% Coverage
0.0% 0.0% Duplication

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 3c103d4 into apache:3.2 Dec 20, 2022
@icodening icodening deleted the issue_5900 branch December 26, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants