Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update IPv6 annotation and filter invalid IPv6 #11266

Merged
merged 2 commits into from
Jan 10, 2023
Merged

update IPv6 annotation and filter invalid IPv6 #11266

merged 2 commits into from
Jan 10, 2023

Conversation

HHoflittlefish777
Copy link
Contributor

need discussion：
Invalid IPv6 address only filter

  • Any Local Address
  • Link Local Address
  • Loopback Address

but there still some invalid address need filter:

  • Site Local Address, which was discarded, but some address may be deployed.
  • Unique Local Address, use to replace Site Local Address, which same to private address in IPv4

AlbumenJ
AlbumenJ approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinliujie
Copy link
Contributor

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit c06c11c into apache:3.2 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinliujie qinliujie qinliujie approved these changes

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HHoflittlefish777 @qinliujie @AlbumenJ