Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics #11315

Merged
merged 5 commits into from
Jan 17, 2023
Merged

metrics #11315

merged 5 commits into from
Jan 17, 2023

Conversation

jojocodeX
Copy link
Contributor

Added metrics for failed request total

…beta.3

# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/stat/MetricsStatComposite.java
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/event/RequestEvent.java
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MetricsKey.java
#	dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/collector/AggregateMetricsCollector.java
#	dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/MetricsFilterTest.java
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

52.6% 52.6% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11315 (279bfe9) into 3.2 (62ccf46) will decrease coverage by 4.56%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##                3.2   #11315      +/-   ##
============================================
- Coverage     69.74%   65.18%   -4.57%     
+ Complexity      118       14     -104     
============================================
  Files          1513     1485      -28     
  Lines         81005    62243   -18762     
  Branches      14362     9122    -5240     
============================================
- Hits          56496    40570   -15926     
+ Misses        19684    17460    -2224     
+ Partials       4825     4213     -612     
Impacted Files Coverage Δ
...o/metrics/collector/AggregateMetricsCollector.java 84.41% <50.00%> (-9.40%) ⬇️
...mon/metrics/collector/DefaultMetricsCollector.java 98.90% <100.00%> (-0.09%) ⬇️
...n/metrics/collector/stat/MetricsStatComposite.java 98.38% <100.00%> (ø)
...pache/dubbo/common/metrics/event/RequestEvent.java 86.66% <100.00%> (+0.95%) ⬆️
.../apache/dubbo/common/metrics/model/MetricsKey.java 100.00% <100.00%> (ø)
...e/dubbo/metrics/filter/MetricsCollectExecutor.java 86.20% <100.00%> (-2.53%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 464 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj chickenlj added this to the 3.2.0 milestone Jan 17, 2023
@chickenlj chickenlj merged commit 664593c into apache:3.2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants