Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics key duplication #11349

Merged

Conversation

jojocodeX
Copy link
Contributor

metrics key duplication

…beta.3

# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/stat/MetricsStatComposite.java
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/event/RequestEvent.java
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MetricsKey.java
#	dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/collector/AggregateMetricsCollector.java
#	dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/MetricsFilterTest.java
…ture-dubbo-3.2.0-beta.3

# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
#	dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/MetricsFilterTest.java
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11349 (952b995) into 3.2.0-beta.4-release (9ab01f4) will decrease coverage by 1.05%.
The diff coverage is 100.00%.

@@                    Coverage Diff                     @@
##             3.2.0-beta.4-release   #11349      +/-   ##
==========================================================
- Coverage                   65.89%   64.84%   -1.05%     
+ Complexity                     20       14       -6     
==========================================================
  Files                        1486     1486              
  Lines                       62356    62352       -4     
  Branches                     9165     9132      -33     
==========================================================
- Hits                        41091    40435     -656     
- Misses                      17070    17718     +648     
- Partials                     4195     4199       +4     
Impacted Files Coverage Δ
...mon/metrics/collector/DefaultMetricsCollector.java 98.90% <100.00%> (ø)
.../apache/dubbo/common/metrics/model/MetricsKey.java 100.00% <100.00%> (ø)
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
... and 110 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit d11fe5f into apache:3.2.0-beta.4-release Jan 19, 2023
@jojocodeX jojocodeX deleted the feature-dubbo-3.2.0-beta.3 branch February 1, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants