Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo 3.2 Rest easyrest response add adaptation #12264

Merged
merged 19 commits into from May 11, 2023

Conversation

jojocodeX
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #12264 (3411ee0) into 3.2 (83240f5) will decrease coverage by 0.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12264      +/-   ##
============================================
- Coverage     69.87%   69.38%   -0.50%     
+ Complexity      341        2     -339     
============================================
  Files          3406     1606    -1800     
  Lines        159482    66216   -93266     
  Branches      26586     9712   -16874     
============================================
- Hits         111443    45941   -65502     
+ Misses        38344    15838   -22506     
+ Partials       9695     4437    -5258     

see 1995 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@suncairong163
Copy link
Contributor

@AlbumenJ javax.ws.rs.core.Response 适配

Comment on lines +61 to +67
Class<?> builtResponse = ClassUtils.forName("org.jboss.resteasy.specimpl.BuiltResponse");

Object o = builtResponse.newInstance();

Method method = builtResponse.getMethod("setEntity", Object.class);

method.invoke(o, new String(body, StandardCharsets.UTF_8));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle NPE here

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 66eff80 into apache:3.2 May 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants