Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail fast when protocol exp #12361

Merged
merged 5 commits into from Jun 12, 2023
Merged

fail fast when protocol exp #12361

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a7d20c
fail fast when protocol exp
wxbty May 21, 2023
ee5bd10
use hasExtension
wxbty May 21, 2023
81cc9a7
Adjust the spi detection position
wxbty Jun 3, 2023
10056f5
remove unuse
wxbty Jun 3, 2023
815fbb6
remove unuse
wxbty Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...o-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@
import org.apache.dubbo.metrics.event.MetricsEventBus;
import org.apache.dubbo.metrics.registry.event.RegistryEvent;
import org.apache.dubbo.registry.AddressListener;
import org.apache.dubbo.registry.support.SkipFailbackWrapperException;
import org.apache.dubbo.remoting.Constants;
import org.apache.dubbo.rpc.Invoker;
import org.apache.dubbo.rpc.Protocol;
Expand Down Expand Up @@ -447,6 +448,10 @@ private boolean checkProtocolValid(String queryProtocols, URL providerUrl) {
if (providerUrl.getProtocol().equals(acceptProtocol)) {
accept = true;
break;
} else {
if (!moduleModel.getApplicationModel().getExtensionLoader(Protocol.class).hasExtension(acceptProtocol)) {
throw new SkipFailbackWrapperException(new IllegalStateException("No such extension org.apache.dubbo.rpc.Protocol by name " + acceptProtocol + ", please check whether related SPI module is missing"));
}
}
}

Expand Down
3 changes: 3 additions & 0 deletions .../dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/FailbackRegistry.java
View file
Open in desktop
Expand Up @@ -366,6 +366,9 @@ protected void notify(URL url, NotifyListener listener, List<URL> urls) {
} catch (Exception t) {
// Record a failed registration request to a failed list
logger.error(REGISTRY_FAILED_NOTIFY_EVENT, "", "", "Failed to notify addresses for subscribe " + url + ", cause: " + t.getMessage(), t);
if (t instanceof SkipFailbackWrapperException) {
throw t;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is these still necessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove it

}
}

Expand Down