Bugfix: Use metric obj for key of LongContainer to fix split bug #12664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.2 #12664 +/- ##
=============================================
+ Coverage 68.68% 69.39% +0.71%
+ Complexity 341 2 -339
=============================================
Files 3615 1629 -1986
Lines 168637 67410 -101227
Branches 28030 9888 -18142
=============================================
- Hits 115820 46780 -69040
+ Misses 42759 16107 -26652
+ Partials 10058 4523 -5535 see 2018 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When the version has the _ symbol, there is an error in getting the rt indicator.
Brief changelog
Use metric obj for key
Verifying this change
MetricsFilterTest modify VERSION = "1.0.0_BETA"
invoke testSucceedRequests method failed before pr and success after pr