Metrics event split #12888
Merged
Metrics event split #12888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.3 #12888 +/- ##
============================================
+ Coverage 65.81% 68.27% +2.46%
Complexity 6 6
============================================
Files 1843 1716 -127
Lines 73722 70661 -3061
Branches 10465 10243 -222
============================================
- Hits 48517 48246 -271
+ Misses 20489 17715 -2774
+ Partials 4716 4700 -16 see 280 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@songxiaosheng @wxbty PTAL |
wxbty
reviewed
Aug 15, 2023
...o-metrics/dubbo-metrics-event/src/main/java/org/apache/dubbo/metrics/event/MetricsEvent.java
Outdated
Show resolved
Hide resolved
...s-metadata/src/test/java/org/apache/dubbo/metrics/metadata/MetadataMetricsCollectorTest.java
Outdated
Show resolved
Hide resolved
|
please fix confict |
# Conflicts: # dubbo-metrics/dubbo-metrics-event/src/main/java/org/apache/dubbo/metrics/event/MetricsEventBus.java
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
As a part of dubbo-core refactor, we need to split out the event-related API out of dubbo-metrics-api. This allows users to import only the event API related to the module they are using, rather than all of it.
Brief changelog
This PR contains only dubbo-metrics-event. The plugin packages are not split so far.