Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-SPI] Spring spi support inject by type #1456

Closed
wants to merge 2 commits into from
Closed

[Dubbo-SPI] Spring spi support inject by type #1456

wants to merge 2 commits into from

Conversation

chickenlj
Copy link
Contributor

@chickenlj chickenlj commented Mar 12, 2018

What is the purpose of the change

Spring spi support inject by type. Not necessary to support spring 2.5 or lower.

Brief changelog

SpringExtensionFactory

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #1456 into master will decrease coverage by 0.02%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
- Coverage   31.59%   31.57%   -0.03%     
==========================================
  Files         682      682              
  Lines       33035    33046      +11     
  Branches     6592     6596       +4     
==========================================
- Hits        10438    10433       -5     
- Misses      20748    20757       +9     
- Partials     1849     1856       +7
Impacted Files Coverage Δ
...onfig/spring/extension/SpringExtensionFactory.java 33.33% <27.27%> (-5.13%) ⬇️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) ⬇️
...a/dubbo/remoting/transport/netty/NettyChannel.java 61.25% <0%> (-5%) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 55.22% <0%> (-1.5%) ⬇️
...baba/dubbo/remoting/transport/mina/MinaClient.java 57.97% <0%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd8ddc...5e7636e. Read the comment docs.


for (ApplicationContext context : contexts) {
try {
return context.getBean(type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whether the getBean() returns null or not, this line will end the function progress, is it the real purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider multiple matching conditions for the same interface type.

@chickenlj
Copy link
Contributor Author

See #1837 .
Close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants