Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dubbo-1920] remove commons-lang3 dependency #1921

Merged
merged 2 commits into from
Jun 12, 2018
Merged

[dubbo-1920] remove commons-lang3 dependency #1921

merged 2 commits into from
Jun 12, 2018

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue#1920: remove commons-lang3 dependency

Brief changelog

dependencies-bom/pom.xml
dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/StringUtils.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/StringUtilsTest.java
dubbo-plugin/dubbo-qos/pom.xml
dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/textui/TKv.java
dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/textui/TLadder.java
dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/textui/TTable.java
dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/textui/TTree.java

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #1921 into master will increase coverage by 0.07%.
The diff coverage is 76.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1921      +/-   ##
===========================================
+ Coverage     49.53%   49.6%   +0.07%     
- Complexity     4508    4539      +31     
===========================================
  Files           558     558              
  Lines         24360   24427      +67     
  Branches       4319    4336      +17     
===========================================
+ Hits          12067   12118      +51     
- Misses        10433   10435       +2     
- Partials       1860    1874      +14
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/alibaba/dubbo/qos/textui/TKv.java 66.66% <ø> (ø) 5 <0> (ø) ⬇️
...ain/java/com/alibaba/dubbo/qos/textui/TLadder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../main/java/com/alibaba/dubbo/qos/textui/TTree.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/qos/server/handler/TelnetProcessHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ubbo/qos/command/decoder/TelnetCommandDecoder.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/com/alibaba/dubbo/qos/textui/TTable.java 77.22% <50%> (ø) 50 <1> (ø) ⬇️
...va/com/alibaba/dubbo/common/utils/StringUtils.java 83.95% <82.08%> (-0.71%) 113 <34> (+34)
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...ba/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9b668...84a5143. Read the comment docs.

@beiwei30 beiwei30 merged commit fc5f60c into apache:master Jun 12, 2018
@beiwei30 beiwei30 deleted the issue1920 branch June 12, 2018 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants