Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference retries default value #2173

Closed
wants to merge 20 commits into from
Closed

Reference retries default value #2173

wants to merge 20 commits into from

Conversation

tswstarplanet
Copy link
Contributor

What is the purpose of the change

Correct the default value of Reference annotation. #2162

@diecui1202
Copy link

@tswstarplanet Why this PR has so many commits, but just change 2 java source files?

@tswstarplanet
Copy link
Contributor Author

@diecui1202 I don't kown. It seems to contains all of the submits since I began to submit PR. But the previous PRs have been merged. Does I make some mistakes about the use of github ?

@diecui1202
Copy link

@tswstarplanet I suggest you checkout a new branch from master, and send a new PR.

How do you think?

@tswstarplanet
Copy link
Contributor Author

@diecui1202 This branch I request to merge was created from my master branch. I do not kown why it is like that. Do I need to delete my repository and fork the official repository once again ?

@diecui1202
Copy link

@tswstarplanet Maybe your local master branch is out of date. Each branch must be created from the newest master, it's the apache/incubator-dubbo 's master, not your fork repo.

@diecui1202
Copy link

➜  incubator-dubbo git:(master) git remote -v
mine	git@github.com:diecui1202/dubbo.git (fetch)
mine	git@github.com:diecui1202/dubbo.git (push)
origin	git@github.com:apache/incubator-dubbo.git (fetch)
origin	git@github.com:apache/incubator-dubbo.git (push)

As the above showing, I checkout to master branch, which is belongs to apache/incubator-dubbo.git, I will run git pull before creating new branches.

After committing on the new branch, I will push it to my own repo. Then create PR.

@tswstarplanet
Copy link
Contributor Author

@diecui1202 If I create a branch from the apache/incubator-dubbo, can I commit code to my own fork and request to merge code ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants