[Dubbo-issue-2178] Please consider supporting Java 8 Date/Time type when serializing with Kryo #2178 #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daryl666
changed the title
chickenlj
requested changes
Aug 9, 2018
| @@ -34,7 +38,7 @@ public Serializer getDefaultSerializer(Class type) { | |||
| throw new IllegalArgumentException("type cannot be null."); | |||
| } | |||
|
|
|||
| if (!type.isArray() && !type.isEnum() && !ReflectionUtils.checkZeroArgConstructor(type)) { | |||
| if (!type.isArray() && !type.isEnum() && !type.equals(LocalDate.class) && !type.equals(LocalDateTime.class) && !type.equals(LocalTime.class) && !ReflectionUtils.checkZeroArgConstructor(type)) { | |||
There was a problem hiding this comment.
Simply check types will not solve the problem.
There was a problem hiding this comment.
Sorry, I've checked that this works, and kryo has internally registered some Serializers for Java 8 Time types.
But we still have a problem, we cannot list all possible classes here.
|
See #2220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Please consider supporting Java 8 Date/Time type when serializing with Kryo #2178
Brief changelog
add the if statement of java8 date/time when getDeclaredConstructor
Verifying this change
org.apache.dubbo.common.serialize.kryo.CompatibleKryo
From Baiji, Term 268, Team 3, Issue #2187, Q3-4