more code review.

[beiwei30]

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
• If this contribution is large, please follow the Software Donation Guide.

[chickenlj]

Will you please take a look at the suggestions from @khanimteyaz.

Also, notice that the Travis CI has passed in master, so please rebase master branch and make sure your PR passes the CI check.

[codecov-io]

Codecov Report

Merging #3083 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #3083      +/-   ##
============================================
- Coverage     63.43%   63.42%   -0.01%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28261    28228      -33     
  Branches       4820     4807      -13     
============================================
- Hits          17926    17904      -22     
+ Misses         8057     8042      -15     
- Partials       2278     2282       +4

Impacted Files	Coverage Δ	Complexity Δ
...java/org/apache/dubbo/rpc/cluster/RouterChain.java	96.87% <ø> (-0.19%)	0 <0> (ø)
...dubbo/rpc/cluster/directory/AbstractDirectory.java	96.96% <0%> (ø)	0 <0> (ø)	⬇️
.../dubbo/registry/integration/RegistryDirectory.java	80% <83.87%> (+7.98%)	0 <0> (ø)	⬇️
...n/java/org/apache/dubbo/common/utils/UrlUtils.java	77.85% <90%> (+0.54%)	0 <0> (ø)	⬇️
.../remoting/transport/netty4/NettyClientHandler.java	75% <0%> (-11.12%)	0% <0%> (ø)
...ava/org/apache/dubbo/config/DubboShutdownHook.java	78.12% <0%> (-6.25%)	0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java	61.17% <0%> (-4.71%)	0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java	67.85% <0%> (-3.58%)	0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java	82.75% <0%> (-3.45%)	0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java	58.69% <0%> (-2.18%)	0% <0%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea4fa5...f597d39. Read the comment docs.

[khanimteyaz]

@beiwei30 do let me know once you are done with your review comments. I will try to give fast-fwd look 😄

[chickenlj]

I am about to give some integration tests on the master branch, this patch seems to work fine.

@beiwei30 If you have other improvement based on the review, please go ahead with a new PR.

[beiwei30]

@khanimteyaz feel free to submit pull request if you need to refactor further.

[khanimteyaz]

Sure.

…

On Sat, Dec 29, 2018 at 1:52 PM Ian Luo ***@***.***> wrote: @khanimteyaz <https://github.com/khanimteyaz> feel free to submit pull request if you need to refactor further. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3083 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdXcPR-vj-ItH4Vp2TuKDVYXTD2ePNcaks5u9yYqgaJpZM4Ziqq3> .