Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish code, avoid dup code #3099

Merged
merged 2 commits into from
Jan 1, 2019
Merged

polish code, avoid dup code #3099

merged 2 commits into from
Jan 1, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Dec 29, 2018

Codecov Report

Merging #3099 into master will decrease coverage by 0.08%.
The diff coverage is 73.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3099      +/-   ##
============================================
- Coverage     63.58%   63.49%   -0.09%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28210    28208       -2     
  Branches       4794     4791       -3     
============================================
- Hits          17938    17912      -26     
- Misses         8007     8027      +20     
- Partials       2265     2269       +4
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 53.34% <100%> (-0.19%) 0 <0> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.69% <100%> (-0.65%) 0 <0> (ø)
...g/apache/dubbo/config/AbstractInterfaceConfig.java 73.26% <73.26%> (-1.82%) 0 <0> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 56.47% <0%> (-5.89%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-2.44%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-2.21%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-2.18%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 71.14% <0%> (-2.02%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9396ace...8b95d42. Read the comment docs.

@zonghaishang
Copy link
Member

Please resolve the code conflict first. @beiwei30

@chickenlj chickenlj merged commit 1bc1312 into apache:master Jan 1, 2019
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants