Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize code: Fix Constructor to determine illegal logic problems #3197

Merged
merged 5 commits into from
Jan 20, 2019
Merged

Optimize code: Fix Constructor to determine illegal logic problems #3197

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b12f1b
Optimize code: Fix Constructor to determine illegal logic problems
Jan 11, 2019
5f4a78d
Optimize code: fix error in judgment logic
Jan 11, 2019
b8b3aaf
java.lang.Class#getDeclaredConstructors all return not null;
Jan 14, 2019
43fde45
Add comments to let everyone understand the changes to the code.
Jan 17, 2019
d279cfc
it's less relevant to why we use constructors.length == 0.
Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,15 @@ private static Object newInstance(Class<?> cls) {
} catch (Throwable t) {
try {
Constructor<?>[] constructors = cls.getDeclaredConstructors();
if (constructors != null && constructors.length == 0) {
/**
* From Javadoc java.lang.Class#getDeclaredConstructors
* This method returns an array of Constructor objects reflecting all the constructors
* declared by the class represented by this Class object.
* This method returns an array of length 0,
* if this Class object represents an interface, a primitive type, an array class, or void.
* So I removed the logical judgment of 'constructors == null'.
*/
if (constructors.length == 0) {
ralf0131 marked this conversation as resolved.
Show resolved Hide resolved
throw new RuntimeException("Illegal constructor: " + cls.getName());
}
Constructor<?> constructor = constructors[0];
Expand Down