Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify some typos #3257

Merged
merged 2 commits into from Jan 17, 2019
Merged

modify some typos #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b3327
modify some typos
mimihom Jan 16, 2019
482fe75
fix some other addionalParameterKeys and paramter typos
mimihom Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,12 @@ public class Constants {
*/
public static final String SIMPLE_CONSUMER_CONFIG_KEY = "simple.consumer.config";
/**
* After simplify the registry, should add some paramter individually for provider.
* After simplify the registry, should add some parameter individually for provider.
* @since 2.7.0
*/
public static final String EXTRA_PROVIDER_CONFIG_KEYS_KEY = "extra.provider.keys";
/**
* After simplify the registry, should add some paramter individually for consumer.
* After simplify the registry, should add some parameter individually for consumer.
*
* @since 2.7.0
*/
Expand Down
4 changes: 2 additions & 2 deletions dubbo-common/src/main/java/org/apache/dubbo/common/Parameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public boolean getBooleanParameter(String key, boolean defaultValue) {
return Boolean.parseBoolean(value);
}

public boolean hasParamter(String key) {
public boolean hasParameter(String key) {
String value = getParameter(key);
return value != null && value.length() > 0;
}
Expand Down Expand Up @@ -234,7 +234,7 @@ public boolean getMethodBooleanParameter(String method, String key, boolean defa
return Boolean.parseBoolean(value);
}

public boolean hasMethodParamter(String method, String key) {
public boolean hasMethodParameter(String method, String key) {
String value = getMethodParameter(method, key);
return value != null && value.length() > 0;
}
Expand Down
2 changes: 1 addition & 1 deletion ...onfig/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ private void verify(Class<?> interfaceClass, Class<?> localClass) {
}

try {
//Check if the localClass a contructor with parameter who's type is interfaceClass
//Check if the localClass a constructor with parameter who's type is interfaceClass
ReflectUtils.findConstructor(localClass, interfaceClass);
} catch (NoSuchMethodException e) {
throw new IllegalStateException("No such constructor \"public " + localClass.getSimpleName() +
Expand Down
4 changes: 2 additions & 2 deletions dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/RegistryConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ public class RegistryConfig extends AbstractConfig {
*/
private Boolean simple;
/**
* After simplify the registry, should add some paramter individually.
* addionalParameterKeys = addParamKeys
* After simplify the registry, should add some parameter individually.
* additionalParameterKeys = addParamKeys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other addionalParameterKeys and paramter typos, you can search them globally and fix them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed and modified the name of the unused method

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

*
* @since 2.7.0
*/
Expand Down
6 changes: 3 additions & 3 deletions ...bo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,11 +398,11 @@ private URL getRegisteredConsumerUrl(final URL consumerUrl, URL registryUrl) {
}

// available to test
public String[] getParamsToRegistry(String[] defaultKeys, String[] addionalParameterKeys) {
int additionalLen = addionalParameterKeys.length;
public String[] getParamsToRegistry(String[] defaultKeys, String[] additionalParameterKeys) {
int additionalLen = additionalParameterKeys.length;
String[] registryParams = new String[defaultKeys.length + additionalLen];
System.arraycopy(defaultKeys, 0, registryParams, 0, defaultKeys.length);
System.arraycopy(addionalParameterKeys, 0, registryParams, defaultKeys.length, additionalLen);
System.arraycopy(additionalParameterKeys, 0, registryParams, defaultKeys.length, additionalLen);
return registryParams;
}

Expand Down