New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly modification to satisfy more complexing support scenrio such as service Level model #3264
Changes from 11 commits
cd293bf
bace61d
893f794
33a88a0
42c731f
2bb97b6
dca664e
3d02961
8140f0c
6cecd25
b52a6f9
f5374cd
055d656
bbcd2b7
72e2c7c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.registry; | ||
|
||
import org.apache.dubbo.common.URL; | ||
import org.apache.dubbo.common.extension.SPI; | ||
|
||
import java.util.List; | ||
|
||
@SPI | ||
public interface AddressListener { | ||
|
||
/** | ||
* processing when receiving the address list | ||
* | ||
* @param addresses | ||
*/ | ||
void notify(List<URL> addresses); | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,6 +42,8 @@ public class RpcInvocation implements Invocation, Serializable { | |
|
||
private Map<String, String> attachments; | ||
|
||
private Map<Object, Object> attributes = new HashMap<Object, Object>(); | ||
|
||
private transient Invoker<?> invoker; | ||
|
||
public RpcInvocation() { | ||
|
@@ -113,6 +115,14 @@ public void setInvoker(Invoker<?> invoker) { | |
this.invoker = invoker; | ||
} | ||
|
||
public Object put(Object key, Object value) { | ||
return attributes.put(key, value); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need to consider any thread safety here? |
||
} | ||
|
||
public Object get(Object key) { | ||
return attributes.get(key); | ||
} | ||
|
||
@Override | ||
public String getMethodName() { | ||
return methodName; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.rpc.model; | ||
|
||
import org.apache.dubbo.common.extension.SPI; | ||
|
||
@SPI | ||
public interface ApplicationInitListener { | ||
/** | ||
* init the application | ||
*/ | ||
void init(); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,8 @@ | |
|
||
import java.lang.reflect.Method; | ||
import java.util.Map; | ||
import java.util.concurrent.ConcurrentHashMap; | ||
import java.util.concurrent.ConcurrentMap; | ||
|
||
public class ConsumerMethodModel { | ||
private final Method method; | ||
|
@@ -31,8 +33,9 @@ public class ConsumerMethodModel { | |
private final String methodName; | ||
private final boolean generic; | ||
|
||
private final AsyncMethodInfo asyncInfo; | ||
private final ConcurrentMap<String, Object> attributeMap = new ConcurrentHashMap<>(); | ||
|
||
private final AsyncMethodInfo asyncInfo; | ||
|
||
public ConsumerMethodModel(Method method, Map<String, Object> attributes) { | ||
this.method = method; | ||
|
@@ -53,6 +56,10 @@ public Method getMethod() { | |
return method; | ||
} | ||
|
||
public ConcurrentMap<String, Object> getAttributeMap() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Returning the same copy of attributeMap may lead to programatic mistake as many different java file may modify it, we may not have the track of who is modifying what what modifying. Should we not have a put and get method of attribute map it self in this class. What do you say? |
||
return attributeMap; | ||
} | ||
|
||
public Class<?> getReturnClass() { | ||
return returnClass; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we these interface level method documentation? what do you say?