[Dubbo-3629] Fix ServiceConfig duplicate export produces misleading exception #3649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #3629
First, the existing implementation by using two variables for controlling
ServiceConfig
exporting state is not only awkward to code, but also can theoretically lead invalid state transitions (exported
andunexported
both simultaneously true).Secondly, the
exported
is set indoExport()
method which could be called asynchronously, this makes it hard to refactor to prevent duplication exporting.Brief changelog
the following changes are introduced:
exported
andunexported
into oneAtomicInteger
variableexportingStage
.compare and set
exporting state inexport()
andunexport()
methods before doing anything.synchronized
from the two methods.The existing exporting state transition flow is as follows, remains unchanged after this PR :
Verifying this change
Necessary unit-test is added, see
ServiceConfigTest
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.