Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DubboBeanDefinitionParser.parse() Error #3843 #3844

Closed
wants to merge 2 commits into from

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Apr 10, 2019

What is the purpose of the change

fix DubboBeanDefinitionParser.parse() Error #3843
follow polish code #3823

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #3844 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3844      +/-   ##
===========================================
+ Coverage     63.58%   63.6%   +0.02%     
  Complexity       71      71              
===========================================
  Files           708     708              
  Lines         31196   31195       -1     
  Branches       5048    5048              
===========================================
+ Hits          19835   19843       +8     
+ Misses         9080    9073       -7     
+ Partials       2281    2279       -2
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/config/spring/ServiceBean.java 51.59% <ø> (ø) 0 <0> (ø) ⬇️
.../org/apache/dubbo/config/spring/ReferenceBean.java 18.62% <ø> (ø) 0 <0> (ø) ⬇️
...onfig/spring/schema/DubboBeanDefinitionParser.java 67.27% <ø> (-0.15%) 0 <0> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 57.14% <0%> (-5.72%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.72% <0%> (-0.37%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 75.51% <0%> (+3.4%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0%> (+4.34%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b70b3ea...64bf999. Read the comment docs.

Copy link
Contributor

@chenlushun chenlushun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议修改 ServiceBean,因为applicationContext,applicationEventPublisher仅仅只是在本类中使用的,这个BUG应该在DubboBeanDefinitionParser中修改

@CrazyHZM
Copy link
Member Author

不建议修改 ServiceBean,因为applicationContext,applicationEventPublisher仅仅只是在本类中使用的,这个BUG应该在DubboBeanDefinitionParser中修改

是的,这里直接把打印的日志去掉就可以了,这个getter只是为了不再走下面的解析逻辑。所以不需要打印error日志

@CrazyHZM
Copy link
Member Author

resolved #3862

@CrazyHZM CrazyHZM closed this Apr 12, 2019
@CrazyHZM CrazyHZM deleted the parseError branch April 27, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants