Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge thrift #3977

Merged
merged 8 commits into from
May 6, 2019
Merged

merge thrift #3977

merged 8 commits into from
May 6, 2019

Conversation

Leishunyu
Copy link
Contributor

What is the purpose of the change

#3960

Brief changelog

Cover the original thrift

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls. check my comments.

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep the two modules[1] together for a while now.
[1] dubbo-rpc-thrift and dubbo-rpc-native-thrift

So we should upgrade the thrift version to 11 in dubbo-rpc-thrift

@codecov-io
Copy link

codecov-io commented May 5, 2019

Codecov Report

Merging #3977 into master will increase coverage by 0.06%.
The diff coverage is 72.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3977      +/-   ##
============================================
+ Coverage     63.68%   63.74%   +0.06%     
  Complexity       71       71              
============================================
  Files           743      744       +1     
  Lines         32125    32205      +80     
  Branches       5120     5124       +4     
============================================
+ Hits          20458    20529      +71     
- Misses         9322     9326       +4     
- Partials       2345     2350       +5
Impacted Files Coverage Δ Complexity Δ
...ubbo/rpc/protocol/nativethrift/ThriftProtocol.java 72.5% <72.5%> (ø) 0 <0> (?)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 72.78% <0%> (+1.36%) 0% <0%> (ø) ⬇️
...n/java/org/apache/dubbo/common/bytecode/Proxy.java 72.22% <0%> (+1.58%) 0% <0%> (ø) ⬇️
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java 78.57% <0%> (+1.78%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0%> (+2.17%) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77df9d7...7aa6a70. Read the comment docs.

@Leishunyu
Copy link
Contributor Author

I think it's better to keep the two modules[1] together for a while now.
[1] dubbo-rpc-thrift and dubbo-rpc-native-thrift

So we should upgrade the thrift version to 11 in dubbo-rpc-thrift

i think so, i change it

dubbo-test/pom.xml Outdated Show resolved Hide resolved
dubbo-compatible/pom.xml Outdated Show resolved Hide resolved
@beiwei30 beiwei30 dismissed lovepoem’s stale review May 6, 2019 05:59

not valid any longer

@beiwei30 beiwei30 merged commit ceb930e into apache:master May 6, 2019
@beiwei30 beiwei30 mentioned this pull request May 6, 2019
6 tasks
@Leishunyu Leishunyu deleted the merge-thrift branch May 6, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants