Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix telnet not work in some scene (#4007) #4026

Merged
merged 1 commit into from
May 13, 2019
Merged

fix telnet not work in some scene (#4007) #4026

merged 1 commit into from
May 13, 2019

Conversation

fibbery
Copy link

@fibbery fibbery commented May 10, 2019

What is the purpose of the change

fix #4007

Brief changelog

XXXXX

Verifying this change

org.apache.dubbo.common.utils.PojoUtilsTest#test_has_no_nullary_constructor_pojo()

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the pull request, could write a unit test to cover this change?

@ralf0131
Copy link
Contributor

Hey, it looks like the UT is failing, could you please take a look?

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #4026 into master will decrease coverage by 0.67%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4026      +/-   ##
============================================
- Coverage     63.11%   62.44%   -0.68%     
  Complexity      564      564              
============================================
  Files           753      774      +21     
  Lines         32411    34260    +1849     
  Branches       5143     5386     +243     
============================================
+ Hits          20455    21392     +937     
- Misses         9604    10404     +800     
- Partials       2352     2464     +112
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/common/utils/PojoUtils.java 71.5% <42.85%> (+1.07%) 0 <0> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 59.84% <0%> (-2.37%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.54%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e690864...9a1fd97. Read the comment docs.

@ralf0131
Copy link
Contributor

It failed because the license check. I think it is due to that you added a new java file but no have ASF license header.

Rat check: Summary over all files. Unapproved: 1, unknown: 1, generated: 0, approved: 302 licenses.

@fibbery
Copy link
Author

fibbery commented May 13, 2019

@ralf0131
can you help me?
I can't fix this build error

@fibbery
Copy link
Author

fibbery commented May 13, 2019

[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.672 s <<< FAILURE! - in org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest
[ERROR] testStoreProvider  Time elapsed: 2.895 s  <<< ERROR!
java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
        at org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest.testStoreProvider(EtcdMetadataReportTest.java:85)

why occur only in openjdk11 @ralf0131

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge if CI pass. I triggered it manually.

@ralf0131 ralf0131 merged commit 7de8abb into apache:master May 13, 2019
@fibbery fibbery deleted the fixbugs branch May 13, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telnet can't work when parameter has no nullary constructor and some fields is primitive
4 participants