Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: step3, remove constants completely. #4053

Merged
merged 2 commits into from
May 14, 2019
Merged

[DUBBO-3137]: step3, remove constants completely. #4053

merged 2 commits into from
May 14, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue #3137: step3, remove constants completely.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4053 into master will decrease coverage by 0.01%.
The diff coverage is 73.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4053      +/-   ##
============================================
- Coverage        63%   62.99%   -0.02%     
- Complexity      543      544       +1     
============================================
  Files           757      756       -1     
  Lines         32570    32569       -1     
  Branches       5162     5162              
============================================
- Hits          20521    20516       -5     
- Misses         9684     9694      +10     
+ Partials       2365     2359       -6
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <ø> (-17.95%) 0 <0> (ø)
...onfigcenter/consul/ConsulDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/org/apache/dubbo/config/MethodConfig.java 95.12% <ø> (ø) 0 <0> (ø) ⬇️
...enter/support/nacos/NacosDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/monitor/dubbo/DubboMonitorFactory.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...gcenter/support/etcd/EtcdDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 83.33% <ø> (ø) 6 <0> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <ø> (ø) 0 <0> (ø) ⬇️
.../main/java/com/alibaba/dubbo/common/Constants.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24d614...5f1c36b. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look my comment.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 0b380e3 into apache:master May 14, 2019
@beiwei30
Copy link
Member Author

so, now we should move to step4, start to review any constants suitable to move back to its own module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants