Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: move more constants out of ConfigConstants #4092

Merged
merged 1 commit into from
May 20, 2019
Merged

[DUBBO-3137]: move more constants out of ConfigConstants #4092

merged 1 commit into from
May 20, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue #3137: move more constants out of ConfigConstants

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from CrazyHZM May 20, 2019 02:38
@codecov-io
Copy link

Codecov Report

Merging #4092 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4092      +/-   ##
============================================
+ Coverage     62.64%   62.67%   +0.03%     
+ Complexity      545      544       -1     
============================================
  Files           762      762              
  Lines         32752    32752              
  Branches       5162     5162              
============================================
+ Hits          20516    20526      +10     
+ Misses         9875     9868       -7     
+ Partials       2361     2358       -3
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/dubbo/remoting/Constants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 96.96% <ø> (ø) 0 <0> (ø) ⬇️
.../remoting/telnet/support/TelnetHandlerAdapter.java 52.27% <ø> (ø) 0 <0> (ø) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 80.3% <ø> (ø) 0 <0> (ø) ⬇️
...onfigcenter/consul/ConsulDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...che/dubbo/registry/dubbo/DubboRegistryFactory.java 89.74% <ø> (ø) 6 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.2% <ø> (ø) 0 <0> (ø) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 87.87% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/ProtocolConfig.java 92.85% <ø> (ø) 0 <0> (ø) ⬇️
...gcenter/support/etcd/EtcdDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23903ba...f5b761b. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit d0d1a65 into apache:master May 20, 2019
@beiwei30 beiwei30 deleted the issue3137 branch May 20, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants